Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sources to a new browser dir and build target #4754

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Move sources to a new browser dir and build target #4754

merged 3 commits into from
Jan 23, 2025

Conversation

hlwarriner
Copy link
Contributor

We're accumulating more sources under //cobalt and this hopefully organizes things a bit more. This also matches patterns I've seen for other embedders like chrome.

b/383301493

@hlwarriner
Move sources to a new browser dir and build target
d20d55b 
We're accumulating more sources under //cobalt and this hopefully
organizes things a bit more. This also matches patterns I've seen for
other embedders like chrome.

b/383301493
andrewsavage1
andrewsavage1 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@andrewsavage1 andrewsavage1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

cobalt/browser/BUILD.gn Outdated Show resolved Hide resolved
cobalt/browser/BUILD.gn Show resolved Hide resolved
cobalt/browser/BUILD.gn Outdated Show resolved Hide resolved
@hlwarriner
Copy link
Contributor Author

@zhongqiliang can you please take a look at the embedded_resources changes? It builds and the contents of the generated file look unchanged but wondering if you see any issues or have a different opinion about where these belong.

zhongqiliang
zhongqiliang approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@zhongqiliang zhongqiliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it is fine to move the js files under the browser module.

@hlwarriner
Copy link
Contributor Author

LGTM, it is fine to move the js files under the browser module.

Sounds good, thanks!

@hlwarriner hlwarriner merged commit bca0e6a into youtube:main Jan 23, 2025
87 of 88 checks passed
andrewsavage1 pushed a commit to andrewsavage1/cobalt that referenced this pull request Jan 27, 2025
@hlwarriner @andrewsavage1
Move sources to a new browser dir and build target (youtube#4754)
276599c 
We're accumulating more sources under //cobalt and this hopefully
organizes things a bit more. This also matches patterns I've seen for
other embedders like chrome.

b/383301493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsavage1 andrewsavage1 andrewsavage1 approved these changes

@zhongqiliang zhongqiliang zhongqiliang approved these changes

@jellefoks jellefoks Awaiting requested review from jellefoks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hlwarriner @zhongqiliang @andrewsavage1